Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI/CD] Remove redundant steps from workflow: Checkstyle, PMD, Spotbugs #115

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

newtork
Copy link
Contributor

@newtork newtork commented Oct 24, 2024

The following steps are being invoked by default with every mvn clean install already:

(They are listening on maven phase verify.)

Copy link
Member

@MatKuhr MatKuhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The printing is still useful for some of these, no? In particular since they attach it to the action result which can be easier to read than logs?

@newtork
Copy link
Contributor Author

newtork commented Oct 24, 2024

The printing is still useful for some of these

When the preceding build step already fails having clean install then the subsequent steps will not be executed.

In particular since they attach it to the action result which can be easier to read than logs?

Do you mean the workflow summary? The python scripts wrote to them.

While I understand the concern that mvn log is difficult to handle, currently any metric >0 will not be tolerated. Ideally the tables will always have 0,0,0,0,0,... values.
Therefore I'm not sure what benefit such table brings, beyond much better format. The information itself remains the same.

@MatKuhr
Copy link
Member

MatKuhr commented Oct 24, 2024

Agreed, we could add a failure() conditional to the printing, but if the mvn output is readable enough, it's not needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants